first commit!

Thursday, Dec 4. 2008  –  Category: Songbird

yay… just got my first commit to Mozilla’s mozilla-central repo in! this was for bmo bug 354857, and to be honest… was a patch i stole from matt anyway. ;-) you can see it’s a pretty small one-liner, but it’s still nice to get something committed.

one of the things i’ve been working trying to work on is getting Songbird’s XULRunner patches upstreamed as much as possible back to mozilla-central. from my discussions with various distribution maintainers, our #1 roadblock to getting Songbird into distros is the reluctance to ship multiple XULRunners. unfortunately, upstreaming is… non-trivial. some of the patches are pretty Songbird-specific, and will need to be massaged to be more generalised for any app. additionally some of the other patches need to be brought up to date for mozilla-central’s tip.

i’ve only managed to get two up so far (i’ve been tracking the status on Songbird’s wiki). these have, by far, been the two easiest patches – but they’ve been a good exercise to familiarise myself with the review and commit process that Mozilla follows. hopefully i can start tackling some of the more complex ones now.

Tags:

3 Responses to “first commit!”

  1. Vladimir Dzhuvinov Says:

    Oh, good :)

    Here’s one bug that apparently has been fixed in Songbird’s xulrunner and I would very much like to see fixed upstream :)

    https://bugzilla.mozilla.org/show_bug.cgi?id=321595

  2. Doug Warner Says:

    What about smaller modifications to XULRunner to make it possible to overlay changes? Assuming you only make modifications to certain files, modify xulrunner to be able to load in your smaller changeset instead of its normal libraries. This would allow you to ship your customizations on top of a standard xulrunner and make it easier for distros to pick up songbird.

  3. Stephen Lau Says:

    Doug – that’s sort of the plan. I’d like to generalise our Songbird-specific patches into patches that are generic enough that would enable us to load or do the specific things we need. In theory, this sounds good… we’ll see how it works out in practice as I start to work my way through the patches.

Leave a Reply

Comments will be sent to the moderation queue.


Recent posts